Fix torch frontend svds functions #28829
Open
+174
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update accepted dtype to include complex numbers add handling for out argument fix dtype and output format
added its accepted dtypes add handling to compute_uv argument fix output format
fixed testing dtype range making input symmetric positive definite matrix conduct calculation value test externally as the results are supposed to be not unique
generate symmetric positive definite input matrixes with correct dtype range to be tested add different test value methods for different output modes (full_matrices)
test for all valid input dtypes make input symmetric positive-definite matrix add different value tests for different “some” argument values
Sam-Armstrong
requested changes
Sep 30, 2024
There was a problem hiding this comment.
@Daniel4078 there are bunch of small issues that I've pointed out here, but even after fixing these it seems like some of the test cases are failing, primarily with data type issue, such as:
AssertionError: the ground truth framework torch returned a complex128 datatype while the backend torch returned a float64 datatype?
|
@Sam-Armstrong Thank you a lot for the reminder, and sorry for these silly mistakes as I mostly just copy the relavant changes from that branch to this one and forgot some details. I am currently researching on what caused this dtype problems as they are not well documented in those torch function documents. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
fix torch frontend svd functions: linalg.svd, blas_and_lapack_ops.svd and tensor.svd
Related Issue
Closes #28769 and other uncreated issue about those related failing tests
Checklist
Socials